node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

test: drop test-crypto-timing-safe-equal-benchmarks

Open RafaelGSS opened this issue 10 months ago • 6 comments

This has been constantly failing on macOS recently and given to the fact an issue has been opened since 2021 and no one worked on that, we should just drop it. Please note, that timing benchmarks tend to be flaky at some point, so we might want to test it differently.

Refs: https://github.com/nodejs/node/issues/38226

cc: @Trott @mhdawson @richardlau

RafaelGSS avatar Apr 29 '24 18:04 RafaelGSS

Can you remove the flaky entries from the status file as well?

richardlau avatar Apr 29 '24 18:04 richardlau

Can you remove the flaky entries from the status file as well?

Done

RafaelGSS avatar Apr 29 '24 19:04 RafaelGSS

CI: https://ci.nodejs.org/job/node-test-pull-request/58806/

nodejs-github-bot avatar Apr 29 '24 19:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58809/

nodejs-github-bot avatar Apr 30 '24 00:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58813/

nodejs-github-bot avatar Apr 30 '24 05:04 nodejs-github-bot

cc @tniessen

lpinca avatar Apr 30 '24 18:04 lpinca

Landed in b876e00b47ec1e7fe356e6876e19e46c08ccef10

nodejs-github-bot avatar May 01 '24 18:05 nodejs-github-bot