node
node copied to clipboard
nodejs
doc: add environment variables specification
Following https://github.com/nodejs/node/issues/49148 Add documentation for environment variables specifications
@IlyasShabi are you interested in continuing on this? this is the only missing PR from making dotenv stable.
@anonrig sorry for the delay I was on holidays, yes will work on it this weekend.
@GeoffreyBooth AFAIK, the only documentation for parsing env files is from the dotenv package https://github.com/motdotla/dotenv
For adding new features we should update this document. If the changes are breaking, we need to document them clearly. Do you have some suggestions ?
@RedYetiDev your comment is not really helpful or contain any actionable item. please provide direct suggestions.
I have two general concerns with this PR:
This is a lot of text to introduce and then need to maintain; we’re essentially defining our own specification here. Is this specified somewhere already that we can just link to?
What happens when we want to add a new feature that’s not specified, like string interpolation? We just update this spec? Would that be a breaking change?
@GeoffreyBooth there is no direct specification for dotenv other than the documentation. i believe this is the first technical specification of it. i'd like to move with this specification. do you have any blockers?
@RedYetiDev your comment is not really helpful or contain any actionable item. please provide direct suggestions.
Sorry! I'll do a review instead. I didn't mean for it to come off as unhelpful.
