node icon indicating copy to clipboard operation
node copied to clipboard

build: fix --v8-lite-mode build

Open daeyeon opened this issue 9 months ago • 10 comments

Fixes: #52710

This patch modifies the build config to compile the error-causing files under the v8_enable_webassembly condition.

Signed-off-by: Daeyeon Jeong [email protected]

daeyeon avatar Apr 27 '24 17:04 daeyeon

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Apr 27 '24 17:04 nodejs-github-bot

Thank you!

davidfiala avatar Apr 27 '24 23:04 davidfiala

CI: https://ci.nodejs.org/job/node-test-pull-request/58779/

nodejs-github-bot avatar Apr 28 '24 14:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5944/

nodejs-github-bot avatar Apr 28 '24 14:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5944/

nodejs-github-bot avatar Apr 28 '24 14:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5944/

nodejs-github-bot avatar Apr 28 '24 14:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5945/

nodejs-github-bot avatar Apr 29 '24 02:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5945/

nodejs-github-bot avatar Apr 29 '24 02:04 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5945/

nodejs-github-bot avatar Apr 29 '24 02:04 nodejs-github-bot

https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5945/

The CI test error seems to require a fix for #51308.

12:20:46     1480c755c560 8 JS:~functionTwo /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:13:21
12:20:46     1480c755c600 3c JS:~functionOne /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:7:21
12:20:46     
12:20:46     </end perf map content>
12:20:46     
12:20:46         at runSuite (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:145:10)
12:20:46         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:148:1)
12:20:46         at Module._compile (node:internal/modules/cjs/loader:1476:14)
12:20:46         at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
12:20:46         at Module.load (node:internal/modules/cjs/loader:1288:32)
12:20:46         at Module._load (node:internal/modules/cjs/loader:1104:12)
12:20:46         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
12:20:46         at node:internal/main/run_main_module:30:49 {
12:20:46       generatedMessage: false,
12:20:46       code: 'ERR_ASSERTION',
12:20:46       actual: 2,
12:20:46       expected: 0,
12:20:46       operator: 'strictEqual'
12:20:46     }
12:20:46     
12:20:46     Node.js v23.0.0-pre
12:20:46   ...
12:20:46 
12:20:46 Failed tests:
12:20:46 out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js
  ...

Failed tests:
out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js

daeyeon avatar Apr 29 '24 10:04 daeyeon

CI: https://ci.nodejs.org/job/node-test-pull-request/59627/

nodejs-github-bot avatar Jun 03 '24 02:06 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6016/

nodejs-github-bot avatar Jun 03 '24 02:06 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6016/

nodejs-github-bot avatar Jun 03 '24 02:06 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6016/

nodejs-github-bot avatar Jun 03 '24 02:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59628/

nodejs-github-bot avatar Jun 03 '24 04:06 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6017/

nodejs-github-bot avatar Jun 03 '24 06:06 nodejs-github-bot

Rebased the latest main and all tests are green. Please review once more. @anonrig @lpinca @richardlau

daeyeon avatar Jun 03 '24 10:06 daeyeon

Landed in 58711c2f8dbb27faae952f15fcea5796730bdbe1

nodejs-github-bot avatar Jun 03 '24 11:06 nodejs-github-bot