node
node copied to clipboard
nodejs
test: limit stack size in `test-error-serdes`
This should significantly speed up the part of test that exceeds the maximum call stack size and hopefully deflake it on CI.
Might fix: https://github.com/nodejs/node/issues/52630
Stress-test CI: https://ci.nodejs.org/job/node-stress-single-test/497/
For comparison, stress-test CI on main: https://ci.nodejs.org/job/node-stress-single-test/501/
https://ci.nodejs.org/job/node-stress-single-test/499/
The test still fails occasionally but maybe it's less flaky.
test-macOS: test/pummel/test-crypto-timing-safe-equal-benchmarks.js#L109 seems to be failing consistently (5/5) on this PR 🤔 I restarted it a fifth time, that doesn't sound promising though
EDIT: it’s also failing on other PRs, confirming it’s unrelated.
This is strange... IIRC default stack size is lower on 32bit platforms, but it shouldn't be lower than 128KB. 🤔
From the machine that failed, I started node and did:
> process.pid
4172727
# in another terminal
$ cat /proc/4172727/limits
Limit Soft Limit Hard Limit Units
Max cpu time unlimited unlimited seconds
Max file size unlimited unlimited bytes
Max data size unlimited unlimited bytes
Max stack size 8388608 unlimited bytes
8388608 seems to be kernel-side ulimit -s bar, which normally shouldn't be reachable (V8 should throw RangeError before segfaulting)
Default V8 stack limit in Node.js should be shown with node --v8-options | fgrep 'default: --stack-size='.
With v20.8.1 on 32bit x86 I got 864 which is just slightly lower than 64bit's 984...
Is it possible to perform stress-single-test on binary-armv7l? If the test fails consistently there, it might be easier to debug.
I get the same as you on the CI machine:
./node --v8-options | fgrep 'default: --stack-size='
type: int default: --stack-size=864