node
node copied to clipboard
Reduce likelihood of race conditions on keep-alive timeout calculatio…
Added 1 seconds threshold in keepalive timeout client-side Added 1 second threshold in keepalive timeout server-side (expire the socket timeout 1 sec after the announced timeout)
Probably better to use a configurable threshold like in undici keepAliveTimeoutThreshold (https://github.com/nodejs/undici/pull/291)
Review requested:
- [ ] @nodejs/http
- [ ] @nodejs/net
ping @mweberxyz
CI: https://ci.nodejs.org/job/node-test-pull-request/58633/
The commit message and PR title contain a typo
Found the same issue in dotnet -- they went with a 1 second offset as well, so that was a good choice. 👍
Hey, this valuable PR fixes many similar issues for keep-alive
. Is it possible to push this through 👀
CI: https://ci.nodejs.org/job/node-test-pull-request/61582/
Hi, I'd like to help this land to resovle similar issues. Can I continue the work and add @zanettea as a co-author? To me, there are just test cases to be added ~and some commits to be rebased to dodge the flakiness on CI~.
The new PR was just merged. This one can be closed now. (Thanks to @jazelly, @zanettea and everyone else who worked on it!)