node
node copied to clipboard
Published
20 hours ago •
nodejs
nodejs
src: reduce unnecessary serialization of CLI options in C++
In this patch we split the serialization routine into two different routines: getCLIOptionsValues() for only serializing the key-value pairs and getCLIOptionsInfo() for getting additional information such as help text etc. The former is used a lot more frequently than the latter, which is only used for generating --help and building process.allowedNodeEnvironmentFlags.
getCLIOptionsValues() also adds --no- entries for boolean options so there is no need to special case in the JS land.
This patch also refactors the option serialization routines to use v8::Object constructor that takes key-value pairs in one go to avoid calling Map::Set or Object::Set repeatedly which can go up to a patched prototype.
