node icon indicating copy to clipboard operation
node copied to clipboard

build: --disable-single-executable-application results in link failure

Open mscdex opened this issue 1 year ago • 1 comments

Version

At least v18.x and by the looks of it, everything since

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Configuring with --disable-single-executable-application results in a failed build during the final build steps because the functionality is always being referenced regardless of compile-time configuration and gives an error about no _register_sea.

Additionally I believe I saw some compiled test failures that happened after the above failures, so it seems like there is even more stuff broken with that configuration.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

Additional information

No response

mscdex avatar Feb 12 '24 06:02 mscdex

I think we could just disable the discovery of SEA in the configuration, the code could be compiled in just fine (so some ifdef guards can be lifted to make it compile at least). Unless it's somehow necessary to avoid linking postject into the binary.

joyeecheung avatar Feb 13 '24 14:02 joyeecheung