node
node copied to clipboard
nodejs
report: add `--report-exclude-network` option
New option --report-exclude-network, also available as report.excludeNetwork, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that.
Fixes: https://github.com/nodejs/node/issues/46060
I'm not used to the tests not being in either sequential or parallel. I add some more tests that verify the header.networkInterfaces is missing when this option is set (either by CLI or configuration). I used new test syntax and what not so hopefully that still works in the test/report/ directory.
The https://github.com/nodejs/node/labels/notable-change label has been added by @anonrig.
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anonrig I'm getting a segmentation fault now (after I made the change Joyee recommended). Trying to debug but this is hard
Checks are green! I've had the request label on for awhile but it still hasn't triggered. Did I do it wrong? Maybe the queue is long? Hopefully we can merge soon!
Checks are green! I've had the request label on for awhile but it still hasn't triggered. Did I do it wrong? Maybe the queue is long? Hopefully we can merge soon!
The Jenkins CI is currently restricted due to the (delayed) security release. It will be reenabled once the security release is done.
🤞 rebased on main and trying CI again. Failures seemed unrelated to my changes.
Commit Queue failed
- Loading data for nodejs/node/pull/51645 ✔ Done loading data for nodejs/node/pull/51645 ----------------------------------- PR info ------------------------------------ Title report: add `--report-exclude-network` option (#51645) Author Ethan Arrowoodhttps://github.com/nodejs/node/actions/runs/7923747889(@Ethan-Arrowood) Branch Ethan-Arrowood:fix/process-getreport -> nodejs:main Labels c++, semver-minor, lib / src, notable-change, needs-ci, report Commits 1 - report: add `--report-exclude-network` option Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - report: add `--report-exclude-network` option ℹ This PR was created on Fri, 02 Feb 2024 03:17:12 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-02-15T15:18:08Z: https://ci.nodejs.org/job/node-test-pull-request/57100/ - Querying data for job/node-test-pull-request/57100/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
If you like at all of the CI runs for this PR it has only failed flaky tests. There is nothing failing consistently, so I believe this is safe to land
Commit Queue failed
- Loading data for nodejs/node/pull/51645 ✔ Done loading data for nodejs/node/pull/51645 ----------------------------------- PR info ------------------------------------ Title report: add `--report-exclude-network` option (#51645) Author Ethan Arrowoodhttps://github.com/nodejs/node/actions/runs/8114994573(@Ethan-Arrowood) Branch Ethan-Arrowood:fix/process-getreport -> nodejs:main Labels c++, semver-minor, lib / src, notable-change, needs-ci, report Commits 1 - report: add `--report-exclude-network` option Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - report: add `--report-exclude-network` option ℹ This PR was created on Fri, 02 Feb 2024 03:17:12 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-01T16:27:31Z: https://ci.nodejs.org/job/node-test-pull-request/57536/ - Querying data for job/node-test-pull-request/57536/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Commit-queue failed because I pushed a rebase after latest reviews. Can someone reapprove this please? @anonrig @joyeecheung