node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

node-api: make napi_get_buffer_info check if passed buffer is valid

Open Janrupf opened this issue 1 year ago • 15 comments

Fixes #51570

Janrupf avatar Jan 26 '24 17:01 Janrupf

Review requested:

  • [ ] @nodejs/node-api

nodejs-github-bot avatar Jan 26 '24 17:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56960/

nodejs-github-bot avatar Jan 29 '24 22:01 nodejs-github-bot

Fixed the linting errors, however, I have no idea why the test suddenly blew up on macOS. Possibly flaky?

Janrupf avatar Jan 30 '24 20:01 Janrupf

@Janrupf kicked off another CI, I should have waited until the local ones had run before doing that earlier, we'll see what the results look like now.

mhdawson avatar Jan 31 '24 22:01 mhdawson

CI: https://ci.nodejs.org/job/node-test-pull-request/56997/

nodejs-github-bot avatar Jan 31 '24 22:01 nodejs-github-bot

Formatting should be good now, though the coverage test failed. I'm not sure if this is related to my changes (seems a bit unlikely)

Janrupf avatar Feb 01 '24 15:02 Janrupf

CI: https://ci.nodejs.org/job/node-test-pull-request/57025/

nodejs-github-bot avatar Feb 02 '24 16:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57048/

nodejs-github-bot avatar Feb 04 '24 19:02 nodejs-github-bot

Jenkins still says its under security embargo, so I have no idea why the tests fail (they do pass locally...), any chance someone could take a look at this/make the logs available?

Janrupf avatar Feb 10 '24 15:02 Janrupf

CI: https://ci.nodejs.org/job/node-test-pull-request/57116/

nodejs-github-bot avatar Feb 15 '24 22:02 nodejs-github-bot

CI seems to be failing due to something unrelated again, @mhdawson mind taking a look?

Janrupf avatar Feb 15 '24 22:02 Janrupf

I think it's been too long to resume the existing ci, kicked off another one, expect it to need to be resumed a few times.

mhdawson avatar Feb 15 '24 23:02 mhdawson

CI: https://ci.nodejs.org/job/node-test-pull-request/57118/

nodejs-github-bot avatar Feb 15 '24 23:02 nodejs-github-bot

@mhdawson CI failed again (sorry for the pings...), this time another random check. I don't think this is related to my changes, but neither can I fully confirm it is not. Any idea if thats a flaky test or something really is broken?

Janrupf avatar Feb 16 '24 01:02 Janrupf

CI: https://ci.nodejs.org/job/node-test-pull-request/57142/

nodejs-github-bot avatar Feb 16 '24 16:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57188/

nodejs-github-bot avatar Feb 20 '24 03:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57196/

nodejs-github-bot avatar Feb 20 '24 10:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57202/

nodejs-github-bot avatar Feb 20 '24 15:02 nodejs-github-bot

Opened - https://github.com/nodejs/node/issues/51813 for latest flaky test failure.

mhdawson avatar Feb 20 '24 15:02 mhdawson

CI: https://ci.nodejs.org/job/node-test-pull-request/57316/

nodejs-github-bot avatar Feb 22 '24 23:02 nodejs-github-bot

Landed in 281c342717f50b98cd44ca27249b600b563d0fec

nodejs-github-bot avatar Feb 23 '24 16:02 nodejs-github-bot