node icon indicating copy to clipboard operation
node copied to clipboard

src: simplify embedder entry point execution.

Open joyeecheung opened this issue 1 year ago • 8 comments

Previously we wrapped the embedder entry point callback into a binding and then invoke the binding from JS land which was a bit convoluted. Now we just call it directly from C++. The main scripts that needed to tail call the embedder callback now return the arguments in an array so that the C++ land can extract the arguments and pass them to the callback. We also set PauseOnNextJavascriptStatement() for --inspect-brk and mark the bootstrap complete milestone directly in C++ for these execution modes.

joyeecheung avatar Jan 24 '24 11:01 joyeecheung

Review requested:

  • [ ] @nodejs/startup

nodejs-github-bot avatar Jan 24 '24 11:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56908/

nodejs-github-bot avatar Jan 24 '24 11:01 nodejs-github-bot

@nodejs/startup @nodejs/cpp-reviewers Can I get some reviews please? Thanks!

joyeecheung avatar Jan 31 '24 10:01 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/57004/

nodejs-github-bot avatar Feb 01 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57021/

nodejs-github-bot avatar Feb 02 '24 14:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57030/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57146/

nodejs-github-bot avatar Feb 16 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57149/

nodejs-github-bot avatar Feb 16 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57158/

nodejs-github-bot avatar Feb 17 '24 16:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57186/

nodejs-github-bot avatar Feb 20 '24 01:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57209/

nodejs-github-bot avatar Feb 20 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57220/

nodejs-github-bot avatar Feb 20 '24 22:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57226/

nodejs-github-bot avatar Feb 21 '24 01:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57272/

nodejs-github-bot avatar Feb 21 '24 21:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57282/

nodejs-github-bot avatar Feb 22 '24 03:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57293/

nodejs-github-bot avatar Feb 22 '24 15:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57313/

nodejs-github-bot avatar Feb 22 '24 22:02 nodejs-github-bot

Landed in f29d2b7053e88517414dd419ed3a18df54a509fb

nodejs-github-bot avatar Feb 23 '24 01:02 nodejs-github-bot