node
node copied to clipboard
src: simplify embedder entry point execution.
Previously we wrapped the embedder entry point callback into a binding and then invoke the binding from JS land which was a bit convoluted. Now we just call it directly from C++. The main scripts that needed to tail call the embedder callback now return the arguments in an array so that the C++ land can extract the arguments and pass them to the callback. We also set PauseOnNextJavascriptStatement()
for --inspect-brk and mark the bootstrap complete milestone directly in C++ for these execution modes.
Review requested:
- [ ] @nodejs/startup
CI: https://ci.nodejs.org/job/node-test-pull-request/56908/
@nodejs/startup @nodejs/cpp-reviewers Can I get some reviews please? Thanks!
CI: https://ci.nodejs.org/job/node-test-pull-request/57004/
CI: https://ci.nodejs.org/job/node-test-pull-request/57021/
CI: https://ci.nodejs.org/job/node-test-pull-request/57030/
CI: https://ci.nodejs.org/job/node-test-pull-request/57146/
CI: https://ci.nodejs.org/job/node-test-pull-request/57149/
CI: https://ci.nodejs.org/job/node-test-pull-request/57158/
CI: https://ci.nodejs.org/job/node-test-pull-request/57186/
CI: https://ci.nodejs.org/job/node-test-pull-request/57209/
CI: https://ci.nodejs.org/job/node-test-pull-request/57220/
CI: https://ci.nodejs.org/job/node-test-pull-request/57226/
CI: https://ci.nodejs.org/job/node-test-pull-request/57272/
CI: https://ci.nodejs.org/job/node-test-pull-request/57282/
CI: https://ci.nodejs.org/job/node-test-pull-request/57293/
CI: https://ci.nodejs.org/job/node-test-pull-request/57313/
Landed in f29d2b7053e88517414dd419ed3a18df54a509fb