node icon indicating copy to clipboard operation
node copied to clipboard

tools: update doc to new version

Open nodejs-github-bot opened this issue 1 year ago • 9 comments

This is an automated update of doc to new version.

nodejs-github-bot avatar Dec 17 '23 00:12 nodejs-github-bot

Review requested:

  • [ ] @nodejs/web-infra

nodejs-github-bot avatar Dec 17 '23 00:12 nodejs-github-bot

I think this update should be split into several commits to prevent commit message lint failure

marco-ippolito avatar Dec 17 '23 10:12 marco-ippolito

This is blocked by https://github.com/micromark/micromark/pull/157, see https://github.com/nodejs/node/pull/49988#issuecomment-1781469110

aduh95 avatar Dec 17 '23 10:12 aduh95

running a full CI cycle to check if this can get unblocked

MoLow avatar Apr 21 '24 07:04 MoLow

CI: https://ci.nodejs.org/job/node-test-pull-request/58567/

nodejs-github-bot avatar Apr 21 '24 07:04 nodejs-github-bot

still failing

10:25:08 export const unicodePunctuation = regexCheck(/\p{P}|\p{S}/u);
10:25:08                                              ^^^^^^^^^^^^^^
10:25:08 
10:25:08 SyntaxError: Invalid regular expression: /\p{P}|\p{S}/u: Invalid property name
10:25:08     at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
10:25:08     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
10:25:08     at callTranslator (node:internal/modules/esm/loader:428:14)
10:25:08     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:434:30)

MoLow avatar Apr 21 '24 07:04 MoLow

amended commit otherwise we will never land this, I'll fix the tool in another PR

marco-ippolito avatar May 08 '24 09:05 marco-ippolito