node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

[18.x] vm: backport vm-related fixes

Open joyeecheung opened this issue 1 year ago • 16 comments

This backport includes the patches of Symbols as WeakMap keys from https://bugs.chromium.org/p/v8/issues/detail?id=12947 and the following PRs:

  • https://github.com/nodejs/node/pull/49855
  • https://github.com/nodejs/node/pull/48943
  • https://github.com/nodejs/node/pull/49874
  • https://github.com/nodejs/node/pull/49391
  • https://github.com/nodejs/node/pull/48510
  • https://github.com/nodejs/node/pull/49671
  • https://github.com/nodejs/node/pull/49710
  • https://github.com/nodejs/node/pull/49950
  • https://github.com/nodejs/node/pull/50137

joyeecheung avatar Dec 01 '23 19:12 joyeecheung

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Dec 01 '23 19:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56036/

nodejs-github-bot avatar Dec 01 '23 19:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5697/

nodejs-github-bot avatar Dec 01 '23 19:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5697/

nodejs-github-bot avatar Dec 01 '23 19:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5697/

nodejs-github-bot avatar Dec 01 '23 20:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56040/

nodejs-github-bot avatar Dec 01 '23 20:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5698/

nodejs-github-bot avatar Dec 01 '23 20:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5698/

nodejs-github-bot avatar Dec 01 '23 20:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5698/

nodejs-github-bot avatar Dec 01 '23 21:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56044/

nodejs-github-bot avatar Dec 02 '23 08:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56228/

nodejs-github-bot avatar Dec 11 '23 14:12 nodejs-github-bot

Hey @joyeecheung, any idea when this may be released? Hoping for the performance improvements between jest and Node v18. Thanks for taking care of all this 🙏

KyleProdigy avatar Dec 15 '23 21:12 KyleProdigy

That would be a decision up to the @nodejs/release team. Since v18 is in maintenance mode this won't be released unless they see a need for it.

joyeecheung avatar Dec 16 '23 13:12 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/56789/

nodejs-github-bot avatar Jan 15 '24 13:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56800/

nodejs-github-bot avatar Jan 16 '24 01:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56813/

nodejs-github-bot avatar Jan 16 '24 15:01 nodejs-github-bot

Landed in 902d8b3d4b60...fe66e9d06e3e.

richardlau avatar Mar 15 '24 18:03 richardlau

🚀♥️

SimenB avatar Mar 15 '24 18:03 SimenB