node icon indicating copy to clipboard operation
node copied to clipboard

test: remove unnecessary noop function args to `musNotCall()`

Open aduh95 opened this issue 1 year ago • 3 comments

aduh95 avatar Jun 21 '23 18:06 aduh95

s/musNotCall/mustNotCall/ in commit message

mscdex avatar Jun 21 '23 18:06 mscdex

CI: https://ci.nodejs.org/job/node-test-pull-request/52328/

nodejs-github-bot avatar Jun 21 '23 18:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52335/

nodejs-github-bot avatar Jun 21 '23 21:06 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/48513
✔  Done loading data for nodejs/node/pull/48513
----------------------------------- PR info ------------------------------------
Title      test: remove unnecessary noop function args to `musNotCall()` (#48513)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:must-not-noop -> nodejs:main
Labels     test, author ready, needs-ci
Commits    2
 - test: remove unnecessary noop function args to `musNotCall()`
 - amend! test: remove unnecessary noop function args to `musNotCall()`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/48513
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Harshitha K P 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48513
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Harshitha K P 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 21 Jun 2023 18:23:06 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491447001
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491730123
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/48513#pullrequestreview-1492586924
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-21T21:50:47Z: https://ci.nodejs.org/job/node-test-pull-request/52335/
- Querying data for job/node-test-pull-request/52335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48513
From https://github.com/nodejs/node
 * branch                  refs/pull/48513/merge -> FETCH_HEAD
✔  Fetched commits as e9340038114f..3eb2f919471f
--------------------------------------------------------------------------------
[main dfb982fc7f] test: remove unnecessary noop function args to `musNotCall()`
 Author: Antoine du Hamel 
 Date: Wed Jun 21 20:18:12 2023 +0200
 14 files changed, 17 insertions(+), 18 deletions(-)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip' On branch main Your branch is ahead of 'origin/main' by 1 commit. (use "git push" to publish your local commits)

Cherry-pick currently in progress. (run "git cherry-pick --continue" to continue) (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files: (use "git add ..." to include in what will be committed) labels.json output

nothing added to commit but untracked files present (use "git add" to track) ✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/5359408246

nodejs-github-bot avatar Jun 23 '23 18:06 nodejs-github-bot

Landed in https://github.com/nodejs/node/commit/d9f394e60720f373465cb8b3958b6e189f9d85a6

aduh95 avatar Jun 24 '23 14:06 aduh95