node icon indicating copy to clipboard operation
node copied to clipboard

src: support sync 'overlapped' stdio option

Open bnoordhuis opened this issue 1 year ago • 2 comments

Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync().

Fixes: https://github.com/nodejs/node/issues/48476 Refs: https://github.com/nodejs/node/pull/29412

bnoordhuis avatar Jun 17 '23 07:06 bnoordhuis

Failed to start CI
- Validating Jenkins credentials
✘  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/5305271123

github-actions[bot] avatar Jun 18 '23 19:06 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52296/

nodejs-github-bot avatar Jun 20 '23 21:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59103/

nodejs-github-bot avatar May 11 '24 14:05 nodejs-github-bot

Related CI failures:

not ok 394 parallel/test-child-process-stdio-overlapped
  ---
  duration_ms: 235.92300
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:408
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(error)
    
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/test/parallel/test-child-process-stdio-overlapped.js:48:8)
        at Module._compile (node:internal/modules/cjs/loader:1434:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1518:10)
        at Module.load (node:internal/modules/cjs/loader:1249:32)
        at Module._load (node:internal/modules/cjs/loader:1065:12)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:12)
        at node:internal/main/run_main_module:30:49 {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: undefined,
      expected: true,
      operator: '=='
    }
    
    Node.js v23.0.0-pre

aduh95 avatar May 11 '24 18:05 aduh95