node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

vm: support negative number lineOffset and columnOffset

Open sinkhaha opened this issue 1 year ago • 1 comments

Fixes: https://github.com/nodejs/node/issues/43207

Checklist

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

sinkhaha avatar May 25 '23 07:05 sinkhaha

cc @bnoordhuis

sinkhaha avatar May 26 '23 09:05 sinkhaha

Can this PR be merged

sinkhaha avatar Jul 11 '23 13:07 sinkhaha

👋 @sinkhaha ! Thanks for your contribution! Looks like somebody else opened a duplicate issue and the fix was merged before this PR was completed. Apologies for the overlap. The fix landed in Node 20.

This as a duplicate of https://github.com/nodejs/node/pull/49855

fhinkel avatar Jan 28 '24 15:01 fhinkel