nodejs
fix: callback with error if SyncWriteStream writeSync failed
General observation: the way _write() synchronously invokes cb() is wrong(ish). Node normally follows the iron-clad rule that callbacks are always invoked asynchronously, otherwise you can end up overflowing the stack. Ex.:
function again() {
stream._write(buf, 'utf8', again); // RangeError: Maximum call stack size exceeded
}
edit: oh nevermind, this is stream.Writable._write() and the streams code takes care of deferring the callback.
Sorry, I'm still looking for a suitable Windows machine to run Node.js compilation and testing. I will provide an update once there is progress.
@lpinca I've identified the cause. On the Windows platform, it requires manual release of the fd; otherwise, it will block the process from cleaning up the temporary directory upon exiting. Could you please trigger the CI again? Thank you.
😅 Force push let the ci down fatal: reference is not a tree: 7bcb45c7a81c3bba6e9ffa96754329c9facd4aa4.
Also one final request. Can you please change the commit message to something like this?
fs: call the callback with an error if writeSync fails
Thank you.