node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

stream: don't read more than can handle in webstream

Open rluvaton opened this issue 2 years ago • 5 comments

fix #46347

TODO

  • [ ] add tests? how could I test that the memory usage is not rising? 🤔

Cc @mcollina

rluvaton avatar Feb 26 '23 01:02 rluvaton

I think the current behavior in the failing test should be the expected one, why would we need 2 reads?

the failed test is: https://github.com/nodejs/node/blob/b164038c863dd226a4c943148d94c3b14df8c550/test/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js#L174-L209

rluvaton avatar Feb 26 '23 08:02 rluvaton

ping @mcollina

rluvaton avatar Mar 07 '23 17:03 rluvaton

In don't know. I would need to dig deep into this and currently do not have time. Maybe @jasnell has some ideas.

mcollina avatar Mar 08 '23 20:03 mcollina

It looks like this still needs a test.

aduh95 avatar May 21 '24 10:05 aduh95

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar May 21 '24 10:05 github-actions[bot]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

github-actions[bot] avatar Jun 21 '24 00:06 github-actions[bot]