Investigate flaky test-watch-mode (again)

[tniessen]

Test

test-watch-mode

Platform

Other

Console output

................. failed 9 out of 10
F......
=== release test-watch-mode ===
Path: sequential/test-watch-mode
Error: --- stderr ---
(node:162497) ExperimentalWarning: The test runner is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
--- stdout ---
TAP version 13
# Subtest: watch mode
    # Subtest: should watch changes to a file - event loop ended
    ok 1 - should watch changes to a file - event loop ended
      ---
      duration_ms: 5906.611153
      ...
    # Subtest: should watch changes to a failing file
    not ok 2 - should watch changes to a failing file
      ---
      duration_ms: 5788.259684
      failureType: 'testCodeFailure'
      error: |-
        Expected values to be strictly equal:
        
        4 !== 2
        
      code: 'ERR_ASSERTION'
      stack: |-
        Object.<anonymous> (file:///home/runner/work/node/node/test/sequential/test-watch-mode.mjs:98:12)
        process.processTicksAndRejections (node:internal/process/task_queues:95:5)
        async ItTest.run (node:internal/test_runner/test:487:9)
        async Promise.all (index 1)
        async Suite.run (node:internal/test_runner/test:714:7)
      ...
    # Subtest: should not watch when running an non-existing file
    ok 3 - should not watch when running an non-existing file
      ---
      duration_ms: 2114.841664
      ...
    # Subtest: should watch when running an non-existing file - when specified under --watch-path
    ok 4 - should watch when running an non-existing file - when specified under --watch-path # SKIP
      ---
      duration_ms: 204.626377
      ...
    # Subtest: should watch changes to a file - event loop blocked
    ok 5 - should watch changes to a file - event loop blocked
      ---
      duration_ms: 3607.078136
      ...
    # Subtest: should watch changes to dependencies - cjs
    ok 6 - should watch changes to dependencies - cjs
      ---
      duration_ms: 5882.811789
      ...
    # Subtest: should watch changes to dependencies - esm
    ok 7 - should watch changes to dependencies - esm
      ---
      duration_ms: 5907.785376
      ...
    # Subtest: should restart multiple times
    ok 8 - should restart multiple times
      ---
      duration_ms: 5031.92522
      ...
    # Subtest: should pass arguments to file
    ok 9 - should pass arguments to file
      ---
      duration_ms: 5189.698885
      ...
    # Subtest: should not load --require modules in main process
    ok 10 - should not load --require modules in main process
      ---
      duration_ms: 5671.436746
      ...
    # Subtest: should not load --import modules in main process
    ok 11 - should not load --import modules in main process
      ---
      duration_ms: 4714.783331
      ...
    1..11
not ok 1 - watch mode
  ---
  duration_ms: 6009.677812
  failureType: 'subtestsFailed'
  error: '1 subtest failed'
  code: 'ERR_TEST_FAILURE'
  ...
1..1
# tests 1
# pass 0
# fail 1
# cancelled 0
# skipped 0
# todo 0
# duration_ms 6023.304411
Command: out/Release/node /home/runner/work/node/node/test/sequential/test-watch-mode.mjs

===
=== 1 tests failed
===

Build links

• https://github.com/nodejs/node/actions/runs/3088279098/jobs/4994566319

Additional information

https://github.com/nodejs/node/issues/44655 was closed by https://github.com/nodejs/node/pull/44621, which was merged as 96f072231d88ed3ed4a5422f2e37485b59f39e4d. That very commit failed the test in GitHub actions as shown above...

[MoLow]

I actually ran stress tests on Jenkins - so that was probably missed. opening a PR