node icon indicating copy to clipboard operation
node copied to clipboard

stream: handle a pending BYOB pull request from a released reader

Open daeyeon opened this issue 2 years ago • 2 comments

In order to meet the specification, this includes the followings:

  • Adding the 'release steps' to ReadableStreamController
  • Responding to a current read request through a pull request from a released reader

Refs: https://streams.spec.whatwg.org/#abstract-opdef-readablebytestreamcontroller-releasesteps Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-in-readable-state (Step 3)

Signed-off-by: Daeyeon Jeong [email protected]

daeyeon avatar Sep 17 '22 18:09 daeyeon

/cc @nodejs/whatwg-stream

daeyeon avatar Sep 17 '22 18:09 daeyeon

CI: https://ci.nodejs.org/job/node-test-pull-request/46650/

nodejs-github-bot avatar Sep 18 '22 11:09 nodejs-github-bot

Landed in e213deabe5e513e996bf6c2d7028ed049baab41b

nodejs-github-bot avatar Sep 23 '22 12:09 nodejs-github-bot

Could you please backport this to v16.x? The test/wpt/status/streams.json file is complaining about this in the v16.x release branch.

juanarbol avatar Oct 04 '22 00:10 juanarbol

Sure. I plan to open a PR that contains all commits related to test/wpt/status/streams.json.

daeyeon avatar Oct 04 '22 01:10 daeyeon