node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

test: refactor to await

Open anjanakvellore opened this issue 2 years ago • 1 comments

Changes the promises to async/await in test/parallel/test-debugger-invalid-json.

anjanakvellore avatar Sep 16 '22 21:09 anjanakvellore

CI: https://ci.nodejs.org/job/node-test-pull-request/46664/

nodejs-github-bot avatar Sep 20 '22 03:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46695/

nodejs-github-bot avatar Sep 22 '22 05:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46780/

nodejs-github-bot avatar Sep 25 '22 17:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46787/

nodejs-github-bot avatar Sep 25 '22 23:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46851/

nodejs-github-bot avatar Sep 27 '22 06:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46918/

nodejs-github-bot avatar Sep 29 '22 05:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46940/

nodejs-github-bot avatar Sep 29 '22 14:09 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/44689
✔  Done loading data for nodejs/node/pull/44689
----------------------------------- PR info ------------------------------------
Title      test: refactor to await (#44689)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     anjanakvellore:refactor-test-debugger-invalid-json -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: use await in test-debugger-invalid-json
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44689
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44689
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: use await in test-debugger-invalid-json
   ℹ  This PR was created on Fri, 16 Sep 2022 21:20:22 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44689#pullrequestreview-1113090104
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-29T14:14:20Z: https://ci.nodejs.org/job/node-test-pull-request/46940/
- Querying data for job/node-test-pull-request/46940/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3153811990

nodejs-github-bot avatar Sep 29 '22 18:09 nodejs-github-bot

Landed in 70047b0c340799872d955334e7b92c0d67bfe66d

nodejs-github-bot avatar Sep 29 '22 19:09 nodejs-github-bot

Thanks for the contribution! 🎉

Trott avatar Sep 29 '22 19:09 Trott