node
node copied to clipboard
test: changed promise to async/await in debugger-watcher
Changed all promise chains to async/await pattern in test-debugger-watchers.js
CI: https://ci.nodejs.org/job/node-test-pull-request/46646/
Commit Queue failed
- Loading data for nodejs/node/pull/44687 ✔ Done loading data for nodejs/node/pull/44687 ----------------------------------- PR info ------------------------------------ Title test: changed promise to async/await in debugger-watcher (#44687) Author Pooja Kulkarnihttps://github.com/nodejs/node/actions/runs/3103046225(@Pooja444, first-time contributor) Branch Pooja444:osd-task-2 -> nodejs:main Labels test, code-and-learn, author ready, needs-ci Commits 2 - test: changed promise to async/await in debugger-watcher - test: corrected linting error Committers 1 - “Pooja PR-URL: https://github.com/nodejs/node/pull/44687 Reviewed-By: Franziska Hinkelmann Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44687 Reviewed-By: Franziska Hinkelmann Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Sep 2022 20:50:06 GMT ✔ Approvals: 2 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/44687#pullrequestreview-1111483424 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44687#pullrequestreview-1116388895 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-18T06:53:22Z: https://ci.nodejs.org/job/node-test-pull-request/46646/ - Querying data for job/node-test-pull-request/46646/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44687 From https://github.com/nodejs/node * branch refs/pull/44687/merge -> FETCH_HEAD ✔ Fetched commits as 962b9abbe312..8946bc761dbb -------------------------------------------------------------------------------- [main 6ac878b113] test: changed promise to async/await in debugger-watcher Author: “Pooja Date: Fri Sep 16 13:48:53 2022 -0700 2 files changed, 49 insertions(+), 48 deletions(-) delete mode 100644 test/sequential/test-debugger-watchers.js create mode 100644 test/sequential/test-debugger-watchers.mjs [main 7bd60d2eae] test: corrected linting error Author: “Pooja Date: Fri Sep 16 14:14:57 2022 -0700 1 file changed, 6 insertions(+), 6 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: changed promise to async/await in debugger-watcher
PR-URL: https://github.com/nodejs/node/pull/44687 Reviewed-By: Franziska Hinkelmann [email protected] Reviewed-By: Rich Trott [email protected]
[detached HEAD 34bc2b4064] test: changed promise to async/await in debugger-watcher Author: “Pooja [email protected] Date: Fri Sep 16 13:48:53 2022 -0700 2 files changed, 49 insertions(+), 48 deletions(-) delete mode 100644 test/sequential/test-debugger-watchers.js create mode 100644 test/sequential/test-debugger-watchers.mjs Rebasing (3/4) Rebasing (4/4)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: corrected linting error
PR-URL: https://github.com/nodejs/node/pull/44687 Reviewed-By: Franziska Hinkelmann [email protected] Reviewed-By: Rich Trott [email protected]
[detached HEAD dd433f0d0c] test: corrected linting error Author: “Pooja [email protected] Date: Fri Sep 16 14:14:57 2022 -0700 1 file changed, 6 insertions(+), 6 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add
commit-queue-squash
label to land the PR as one commit, orcommit-queue-rebase
to land as separate commits.
Landed in 269aa6ebba6b
Thank you for the contribution! 🎉