node icon indicating copy to clipboard operation
node copied to clipboard

test: change promise to async/await in test-debugger-help.mjs

Open chanduMe opened this issue 2 years ago • 2 comments

Changes:

  1. Updated the test-debugger-help.js to test-debugger-help.mjs
  2. Updated the test-debugger-help to use async/await instead of a promise.

chanduMe avatar Sep 16 '22 20:09 chanduMe

Welcome @chanduMe and thanks for the pull request. Can you please update the commit message to conform with our requirements? The first line needs to be 5 characters shorter so may this?:

test: use async/await in test-debugger-help

Trott avatar Sep 18 '22 19:09 Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/46663/

nodejs-github-bot avatar Sep 19 '22 20:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46776/

nodejs-github-bot avatar Sep 25 '22 16:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46788/

nodejs-github-bot avatar Sep 25 '22 23:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46852/

nodejs-github-bot avatar Sep 27 '22 06:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46914/

nodejs-github-bot avatar Sep 29 '22 01:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46938/

nodejs-github-bot avatar Sep 29 '22 14:09 nodejs-github-bot

I'm not sure why the macOS test system keeps failing on Jenkins, but I'm going to rebase and force-push in the hope that there's a fix in the code base somewhere that we just need to include here.

Trott avatar Sep 29 '22 18:09 Trott

I'm not sure why the macOS test system keeps failing on Jenkins, but I'm going to rebase and force-push in the hope that there's a fix in the code base somewhere that we just need to include here.

sequential/test-watch-mode-inspect failed. It's not as obvious in Jenkins anymore because the Node.js tap runner means we end up with tap embedded within tap which requires fixes in https://github.com/nodejs/tap2junit -- I'm waiting for a new version to be released (https://github.com/nodejs/tap2junit/issues/41) so I can (easily) deploy the update onto the test infrastructure.

richardlau avatar Sep 29 '22 18:09 richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/46943/

nodejs-github-bot avatar Sep 29 '22 18:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46949/

nodejs-github-bot avatar Sep 29 '22 21:09 nodejs-github-bot

Landed in e236af8d54495c2c358344ba56dd0f7408fece99

nodejs-github-bot avatar Sep 29 '22 23:09 nodejs-github-bot

Thanks for the contribution! 🎉

Trott avatar Sep 30 '22 03:09 Trott