node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

test-debugger-auto-resume - promise to async/await

Open samyuktaprabhu opened this issue 2 years ago • 1 comments

Worked on changing promises to async/await for test-debugger-auto-resume.js file.

samyuktaprabhu avatar Sep 16 '22 18:09 samyuktaprabhu

CI: https://ci.nodejs.org/job/node-test-pull-request/46632/

nodejs-github-bot avatar Sep 17 '22 05:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46755/

nodejs-github-bot avatar Sep 25 '22 02:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46883/

nodejs-github-bot avatar Sep 28 '22 02:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46905/

nodejs-github-bot avatar Sep 28 '22 16:09 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/44675
✔  Done loading data for nodejs/node/pull/44675
----------------------------------- PR info ------------------------------------
Title      test-debugger-auto-resume - promise to async/await (#44675)
Author     M Samyuktha Prabhu  (@samyuktaprabhu, first-time contributor)
Branch     samyuktaprabhu:main -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    2
 - test: update test-debugger-auto-resume to use async/await
 - Update test/sequential/test-debugger-auto-resume.mjs
Committers 2
 - Rich Trott 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/44675
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44675
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 16 Sep 2022 18:51:15 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44675#pullrequestreview-1119363670
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-28T16:11:38Z: https://ci.nodejs.org/job/node-test-pull-request/46905/
- Querying data for job/node-test-pull-request/46905/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @samyuktaprabhu([email protected])
   ⚠  - commit 6ad42a88f940 is authored by [email protected]
   ⚠  - commit 52f07d8466f0 is authored by [email protected]
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3149266853

nodejs-github-bot avatar Sep 29 '22 07:09 nodejs-github-bot

Landed in 2615d7653c40.

Thanks for the contrinbution! 🎉

Trott avatar Sep 29 '22 14:09 Trott