node
node copied to clipboard
nodejs
Migrated from Promise chains to Async/Await
Hi @rathi2016 and thank you for the contribution! The commit message linter is failing because your commit message title does not begin with test: followed by a lowercase imperative verb (see commit message guidelines). It should have the format test: migrate ....
You can fix this by running git commit --amend locally to edit the commit message, followed by git push --force-with-lease.
Welcome, @rathi2016 and thanks for the pull request.
Can you fix these lint issues? (No need to force push to the branch this time. A regular push will do.)
/home/runner/work/node/node/test/sequential/test-debugger-restart-message.js
Error: 31:5 error Closing curly brace does not appear on the same line as the subsequent block brace-style
Error: 31:6 error Trailing spaces not allowed no-trailing-spaces
Error: 32:5 error Expected space(s) after "finally" keyword-spacing
Error: 39:1 error Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
You can check for lint issues locally with make lint-js or vcbuild lint-js.
Thanks!
(Oh, and you can try to auto-fix the issues with make lint-js-fix! I think vcbuild lint-js-fix works too on Windows.)
For sure will do that thanks 😊
On Sat, Sep 17, 2022, 9:43 AM Rich Trott @.***> wrote:
(Oh, and you can try to auto-fix the issues with make lint-js-fix! I think vcbuild lint-js-fix works too on Windows.)
— Reply to this email directly, view it on GitHub https://github.com/nodejs/node/pull/44674#issuecomment-1250074306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQ72T3FEEO47MDMTG2CRTTV6XDH7ANCNFSM6AAAAAAQOSJWYI . You are receiving this because you were mentioned.Message ID: @.***>
@Trott -> make lint-js-fix worked for me thanks ! Do Let me know if there is any additional action required from my end
Commit Queue failed
- Loading data for nodejs/node/pull/44674 ✔ Done loading data for nodejs/node/pull/44674 ----------------------------------- PR info ------------------------------------ Title Migrated from Promise chains to Async/Await (#44674) Author Rathi N Dashttps://github.com/nodejs/node/actions/runs/3148913958(@rathi2016, first-time contributor) Branch rathi2016:rathi-nd-asyn-await-test -> nodejs:main Labels test, code-and-learn, author ready, needs-ci Commits 2 - test: migrated from Promise chains to Async/Await - resolved the lint issue Committers 1 - Rathi N Das PR-URL: https://github.com/nodejs/node/pull/44674 Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44674 Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Sep 2022 18:45:15 GMT ✔ Approvals: 3 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44674#pullrequestreview-1111097463 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44674#pullrequestreview-1121161133 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/44674#pullrequestreview-1121195554 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-27T03:56:15Z: https://ci.nodejs.org/job/node-test-pull-request/46845/ - Querying data for job/node-test-pull-request/46845/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 1b971883e0..cc506f33ab main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 6825a366ef test: add extra tests for basename with ext option - cc506f33ab test: add extra tests for basename with ext option -------------------------------------------------------------------------------- HEAD is now at cc506f33ab test: add extra tests for basename with ext option ✔ Reset to origin/main - Downloading patch for 44674 From https://github.com/nodejs/node * branch refs/pull/44674/merge -> FETCH_HEAD ✔ Fetched commits as cc506f33ab80..ddb211579878 -------------------------------------------------------------------------------- [main 325f381ec5] test: migrated from Promise chains to Async/Await Author: Rathi N Das Date: Fri Sep 16 14:39:39 2022 -0400 1 file changed, 13 insertions(+), 13 deletions(-) [main de3de0c8e4] resolved the lint issue Author: Rathi N Das Date: Sun Sep 18 15:10:29 2022 -0400 1 file changed, 1 insertion(+), 3 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: migrated from Promise chains to Async/Await
PR-URL: https://github.com/nodejs/node/pull/44674 Reviewed-By: Ruben Bridgewater [email protected] Reviewed-By: Rich Trott [email protected] Reviewed-By: Trivikram Kamat [email protected]
[detached HEAD 349eed7d4b] test: migrated from Promise chains to Async/Await Author: Rathi N Das [email protected] Date: Fri Sep 16 14:39:39 2022 -0400 1 file changed, 13 insertions(+), 13 deletions(-) Rebasing (3/4) Rebasing (4/4)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- resolved the lint issue
PR-URL: https://github.com/nodejs/node/pull/44674 Reviewed-By: Ruben Bridgewater [email protected] Reviewed-By: Rich Trott [email protected] Reviewed-By: Trivikram Kamat [email protected]
[detached HEAD c9838b0a2b] resolved the lint issue Author: Rathi N Das [email protected] Date: Sun Sep 18 15:10:29 2022 -0400 1 file changed, 1 insertion(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add
commit-queue-squashlabel to land the PR as one commit, orcommit-queue-rebaseto land as separate commits.