node icon indicating copy to clipboard operation
node copied to clipboard

dns: support dns module in the snapshot

Open joyeecheung opened this issue 2 years ago • 3 comments

For the initial iteration, only the default resolver can be serialized/deserialized. If dns.setServers() has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots.

joyeecheung avatar Sep 14 '22 07:09 joyeecheung

Review requested:

  • [ ] @nodejs/net

nodejs-github-bot avatar Sep 14 '22 07:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46573/

nodejs-github-bot avatar Sep 14 '22 08:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46674/

nodejs-github-bot avatar Sep 20 '22 13:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46815/

nodejs-github-bot avatar Sep 26 '22 12:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46891/

nodejs-github-bot avatar Sep 28 '22 12:09 nodejs-github-bot

Landed in 8821860f11a94e69ba642d874d3226480a68fc1b

joyeecheung avatar Sep 28 '22 18:09 joyeecheung

This depends on https://github.com/nodejs/node/pull/44541; I will mark this as "backport-blocked-v16.x"

juanarbol avatar Oct 04 '22 01:10 juanarbol