node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

doc: add missing step for llhttp update

Open mhdawson opened this issue 2 years ago • 1 comments

Refs: https://github.com/nodejs/node/issues/43946

  • Add instructions on updating llhttp version in file maintained only in Node.js repository as it needs to be kept in sync with what is copied from the llhttp repository when an update is made.

Signed-off-by: Michael Dawson [email protected]

mhdawson avatar Aug 04 '22 20:08 mhdawson

Review requested:

  • [ ] @nodejs/tsc

nodejs-github-bot avatar Aug 04 '22 20:08 nodejs-github-bot

@ShogunPanda, I'll try to pull the suggestions from another thread into this PR sometime this week so we can get it landed.

mhdawson avatar Sep 13 '22 21:09 mhdawson

@mhdawson Please see #44652, it should replace this PR.

ShogunPanda avatar Sep 15 '22 10:09 ShogunPanda

@ShogunPanda thanks, closing this one.

mhdawson avatar Sep 15 '22 15:09 mhdawson