node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

src: trace fs async api

Open theanarkh opened this issue 2 years ago • 1 comments

trace fs async api. @jasnell

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

Affected subsystem: fs

theanarkh avatar Jul 30 '22 17:07 theanarkh

This is really good!

juanarbol avatar Jul 31 '22 00:07 juanarbol

@jasnell @addaleax Hi, can you help review this PR ? Thanks !

theanarkh avatar Aug 22 '22 00:08 theanarkh

CI: https://ci.nodejs.org/job/node-test-pull-request/46276/

nodejs-github-bot avatar Aug 27 '22 19:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46280/

nodejs-github-bot avatar Aug 27 '22 21:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46285/

nodejs-github-bot avatar Aug 28 '22 09:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46288/

nodejs-github-bot avatar Aug 28 '22 14:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/46298/

nodejs-github-bot avatar Aug 28 '22 15:08 nodejs-github-bot

The CI always fails on Windows, but it seems it is not related to this PR.

theanarkh avatar Aug 28 '22 16:08 theanarkh

CI: https://ci.nodejs.org/job/node-test-pull-request/46301/

nodejs-github-bot avatar Aug 28 '22 16:08 nodejs-github-bot

Landed in 60c3077d464492beeeaf8b25a12e36bfd35006f5

nodejs-github-bot avatar Aug 28 '22 18:08 nodejs-github-bot