node
node copied to clipboard
Published
20 hours ago •
nodejs
nodejs
events: use bitset in listener to save memory
There are many other good optimization ideas namely not using a linked list for listeners
I'll be working on that in a separate PR.
CI is locked due to a security release - the process from now (sorry if this is stuff you know, telling you since it's your first code contribution here):
- We wait for CI to unlock and run CI
- We (hopefully) get a second LGTM on this (or review/comments and iterate)
- In 2 days (assuming two approvals) or 7 (assuming just me) this lands in core assuming tests pass and there are no objections
I will also trigger a CI benchmark run for events since we do test perf - might be a good idea to run it locally to practice if you want there is info in [the docs](https://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md.
cc @jasnell @linkgoron for more reviewers probably? (Although Antoine already started reviewing and is also a good reviewer and usually finds useful stuff)
