Linked modules do not get added to the built-in modules

[LeonMrBonnie]

Version

v17.7.0

Platform

Windows

Subsystem

No response

What steps will reproduce the bug?

Compile NodeJS and add a linked module by e.g. using this command:

vcbuild.bat x64 dll link-module ./my-extra-module.js

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

The module should be available as a built-in module when using the resulting binary.

What do you see instead?

The file is missing from the file generated by the js2c script, presumably by faulty refactoring done in the past. (It still worked with NodeJS v14)

Additional information

No response

[ritikBhandari]

Hi, Can I have a try on this issue?

[richardlau]

This affects all platforms, not just Windows. It's an oversight in https://github.com/nodejs/node/pull/39069.

I've opened https://github.com/nodejs/node/pull/48522 to fix.