node icon indicating copy to clipboard operation
node copied to clipboard

http: server check Host header in request, to meet RFC 7230 5.4 requirement

Open wwwzbwcom opened this issue 3 years ago • 5 comments

Relate issues: #3094 #39033

According to RFC 2730 5.4 https://datatracker.ietf.org/doc/html/rfc7230#section-5.4: A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field or a Host header field with an invalid field-value.

wwwzbwcom avatar Jul 09 '21 10:07 wwwzbwcom

could you please add some test cases?

Under test/parellel/

himself65 avatar Jul 09 '21 10:07 himself65

could you please add some test cases?

Under test/parellel/

Working on it.

Also, I wonder how to increamental build under windows, every time I run test or build with ./vcbuild.bat, it compile whole program.

wwwzbwcom avatar Jul 09 '21 11:07 wwwzbwcom

Is there any additional work needed for this PR?

wwwzbwcom avatar Aug 31 '21 16:08 wwwzbwcom

@wwwzbwcom I'm sorry for this PR got staled..

It seems that it is conflict with current master branch. Would you want to resolve it? After that, I would ping http team for further reviewing.

Ayase-252 avatar Oct 07 '21 05:10 Ayase-252

Hey, this would need a rebase to solve the git conflicts.

aduh95 avatar Sep 18 '23 09:09 aduh95