node icon indicating copy to clipboard operation
node copied to clipboard

lib: refactor to use optional chaining

Open pd4d10 opened this issue 3 years ago • 3 comments

This PR migrates expressions such as a ? a.b : c to a?.b ?? c

Codemod script: https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts

Also see: https://github.com/nodejs/node/issues/38609

pd4d10 avatar May 16 '21 08:05 pd4d10

I'm not sure we want to do that after https://github.com/nodejs/node/pull/38245... In any case this should be split into several PRs, it's less of a burden to review smaller PRs and we benchmark it more efficiently.

aduh95 avatar May 16 '21 09:05 aduh95

I'm not sure we want to do that after #38245...

OK. Given this information, I guess we should hold it until the performance issues solved.

pd4d10 avatar May 16 '21 11:05 pd4d10

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar May 05 '24 21:05 github-actions[bot]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]