node icon indicating copy to clipboard operation
node copied to clipboard

test: improve coverage of lib/readline.js

Open pd4d10 opened this issue 3 years ago • 9 comments

Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441 https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L625 https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L634

pd4d10 avatar May 12 '21 09:05 pd4d10

CI run: https://ci.nodejs.org/job/node-test-pull-request/38092/

mhdawson avatar May 14 '21 20:05 mhdawson

CI: https://ci.nodejs.org/job/node-test-pull-request/38092/

nodejs-github-bot avatar May 14 '21 20:05 nodejs-github-bot

Hi, thanks for submitting the code. could you resolve git conflicts? @pd4d10

Lxxyx avatar Jun 11 '21 02:06 Lxxyx

Updated @Lxxyx

pd4d10 avatar Jun 11 '21 13:06 pd4d10

CI: https://ci.nodejs.org/job/node-test-pull-request/38592/

nodejs-github-bot avatar Jun 12 '21 07:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/39746/

nodejs-github-bot avatar Sep 03 '21 02:09 nodejs-github-bot

This needs a rebase

aduh95 avatar May 05 '24 21:05 aduh95

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar May 05 '24 21:05 github-actions[bot]

This needs a rebase

@aduh95 Updated

pd4d10 avatar May 06 '24 10:05 pd4d10

CI: https://ci.nodejs.org/job/node-test-pull-request/59078/

nodejs-github-bot avatar May 10 '24 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59089/

nodejs-github-bot avatar May 11 '24 08:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59126/

nodejs-github-bot avatar May 11 '24 23:05 nodejs-github-bot

Landed in 749b0bfe2c8b6253ec76bf92db70a46a8bccd43b

nodejs-github-bot avatar May 12 '24 07:05 nodejs-github-bot