test: refactor test-cluster-master-error to be more resilient

[addaleax]

Using the filesystem for communication circumvents the issue described in the comment where a new process could end up picking up the process ids that the test case checks for.

Checklist

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x] tests and/or benchmarks are included
• [x] commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33526/

[addaleax]

Interesting that this timed out in one of the Windows tests … might take me a while to get back to that, but it makes me suspect that there’s a chance this is a genuine bug here (since it is flaky both before and after this PR)

[jasnell]

So... On windows, I've seen some flakiness before when calling sync file operations in process exit but that's been on much larger outputs. I'll see if I can investigate tomorrow

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34189/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34265/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34433/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35455/

[aduh95]

@addaleax This needs a rebase.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58954/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58956/

[aduh95]

It looks like this commit is making the test less resilient on Windows – I don't know if I did something wrong when rebasing or what. I'm going to add the stalled label, if someone cares to pick it up and fine what's wrong with it, that'd be awesome, otherwise we can keep the current test as is.

[github-actions[bot]]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions[bot]]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.