node icon indicating copy to clipboard operation
node copied to clipboard

src: set SA_SIGINFO flag when using sa_sigaction

Open richardlau opened this issue 4 years ago • 8 comments

For sigaction() the SA_SIGINFO flag should be set when setting the handler via the sa_sigaction member of the sigaction struct.

This unfortunately doesn't fix https://github.com/nodejs/node/issues/34410 but AFAICT looks correct based on the sigaction() docs.

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

richardlau avatar Aug 06 '20 13:08 richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/32646/

nodejs-github-bot avatar Aug 06 '20 13:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/32647/

nodejs-github-bot avatar Aug 06 '20 15:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/32656/

nodejs-github-bot avatar Aug 06 '20 22:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/32657/

nodejs-github-bot avatar Aug 06 '20 23:08 nodejs-github-bot

So I'm not sure why but it looks like on AIX if reset_handler is set then all members of the siginfo argument passed to the handler are 0. @nodejs/platform-aix any ideas?

richardlau avatar Aug 07 '20 02:08 richardlau

So I'm not sure why but it looks like on AIX if reset_handler is set then all members of the siginfo argument passed to the handler are 0. @nodejs/platform-aix any ideas?

FWIW I've distilled the problem down to https://github.com/richardlau/signals

richardlau avatar Aug 07 '20 11:08 richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/34196/

nodejs-github-bot avatar Nov 08 '20 11:11 nodejs-github-bot

This needs a rebase

aduh95 avatar May 05 '24 20:05 aduh95