node
node copied to clipboard
src: set SA_SIGINFO flag when using sa_sigaction
For sigaction()
the SA_SIGINFO
flag should be set when setting
the handler via the sa_sigaction
member of the sigaction
struct.
This unfortunately doesn't fix https://github.com/nodejs/node/issues/34410 but AFAICT looks correct based
on the sigaction()
docs.
Checklist
- [x]
make -j4 test
(UNIX), orvcbuild test
(Windows) passes - [x] commit message follows commit guidelines
CI: https://ci.nodejs.org/job/node-test-pull-request/32646/
CI: https://ci.nodejs.org/job/node-test-pull-request/32647/
CI: https://ci.nodejs.org/job/node-test-pull-request/32656/
CI: https://ci.nodejs.org/job/node-test-pull-request/32657/
So I'm not sure why but it looks like on AIX if reset_handler
is set then all members of the siginfo
argument passed to the handler are 0
. @nodejs/platform-aix any ideas?
So I'm not sure why but it looks like on AIX if
reset_handler
is set then all members of thesiginfo
argument passed to the handler are0
. @nodejs/platform-aix any ideas?
FWIW I've distilled the problem down to https://github.com/richardlau/signals
CI: https://ci.nodejs.org/job/node-test-pull-request/34196/
This needs a rebase