node-v8
node-v8 copied to clipboard
nodejs
Experimental Node.js mirror on V8 lkgr :sparkles::turtle::rocket::sparkles:
The readme currently does not explain how the ci works. I couldn’t find the source for the node 12 ci line for example. It would be useful to also know...
### Description This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using [secure-workflows](https://github.com/step-security/secure-workflows). The GitHub Actions workflow has a GITHUB_TOKEN with write access to multiple scopes....
https://ci.nodejs.org/job/node-test-commit-smartos/45420/nodes=smartos20-64/console ``` 10:51:08 In file included from ../deps/v8/src/base/free_deleter.h:15, 10:51:08 from ../deps/v8/src/base/debug/stack_trace_posix.cc:41: 10:51:08 ../deps/v8/src/base/platform/memory.h: In function 'std::size_t v8::base::MallocUsableSize(void*)': 10:51:08 ../deps/v8/src/base/platform/memory.h:118:10: error: 'malloc_usable_size' was not declared in this scope; did you mean...
See https://github.com/nodejs/node-v8/actions/runs/6878827246/job/18709360221 It's been happening for some times (several weeks I think). I hoped it would fix itself upstream like it happens sometimes, but unfortunately these errors don't go away....
Considering this was is able to bring memory to the OS and implenet vulnerablities - was this ever used for anything but?
Previous thread: https://github.com/nodejs/node-v8/issues/244
From release CI: https://ci-release.nodejs.org/job/iojs+release/9816/nodes=osx11-x64-release-tar/console ``` 12:43:23 c++ -o /Users/iojs/build/ws/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/wasm-import-wrapper-cache.o ../deps/v8/src/wasm/wasm-import-wrapper-cache.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DV8_TARGET_ARCH_X64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_MACOS' '-DV8_EMBEDDER_STRING="-node.6"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_SHORT_BUILTIN_CALLS' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS'...
See: https://github.com/nodejs/node-v8/actions/runs/6742272834/job/18328109270 Refs: https://github.com/v8/v8/commit/d5631f63d2ea4269b47e0a71bec3b47177073623 This breaks us here: https://github.com/nodejs/node-v8/blob/1ccbbfef3a32dbce7d5f35f17c2280bc995af10e/src/env.cc#L552 And here: https://github.com/nodejs/node-v8/blob/1ccbbfef3a32dbce7d5f35f17c2280bc995af10e/src/env.cc#L583 /cc @nodejs/cpp-reviewers @dharesign
- https://github.com/v8/v8/commit/a1ada7703d2274017ebef4886e9f7404912a63bd - https://github.com/v8/v8/commit/a4cae4e23544179718a3891e70ecf03f7c5fa706 - https://github.com/v8/v8/commit/0b800e55f0560d8f9b84e1ebf0d5485bb6587b1d