node-v8
node-v8 copied to clipboard
Windows MSI installer creates doc shortcut with wrong URL
Meaning this shortcut in Start menu:
For example, in this build:
https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/
Proper URL: https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/docs/api/
Shortcut URL: https://nodejs.org/download/custom/v10.0.0-v8-canary20180306870146ff63/docs/api/ (404)
@nodejs/build
After a quick look it seems that that portion of URL is driven by DistTypeDir
:
https://github.com/nodejs/node-v8/blob/canary/tools/msvs/msi/product.wxs#L261
And that variable is set into build.bat
from server:
https://github.com/nodejs/node-v8/blob/fecbce45d1ad158d7e869b1d294f731704b65cb1/vcbuild.bat#L344
I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?
I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?
DistTypeDir is set in the ci-release job from DISTTYPE, which is a parameter in the job:
![image](https://user-images.githubusercontent.com/15943089/37426651-0ce80f26-27bf-11e8-9278-79c1c33f0856.png)
It should be release for regular releases.
DISTTYPE
and DISTTYPEDIR
are changed to custom
by the build script when building v8-canaries (and others). The correct variable to use should be RELEASE_URLBASE
.
So what needs to be changed to fix this?
Is it still an issue?
For the last Canary build for Windows (as of 2019-01-02), yes, the issue still exists.