node-v8 icon indicating copy to clipboard operation
node-v8 copied to clipboard

build: remove support for s390 32-bit

Open richardlau opened this issue 1 year ago • 3 comments

V8 removed support for it.

Refs: https://github.com/v8/v8/commit/9565a9a721a7f1449be73c03aedc8532571e8bd1


Failure after https://github.com/v8/v8/commit/9565a9a721a7f1449be73c03aedc8532571e8bd1:

  • https://ci-release.nodejs.org/job/iojs+release/10478/nodes=rhel8-s390x-release/console
  • https://ci.nodejs.org/job/node-test-commit-linuxone/45920/nodes=rhel8-s390x/console
11:00:25 running: 
11:00:25     python tools/gyp_node.py --no-parallel -Dconfiguring_node=1 -Dbuild_type=Release -Dpython=/usr/bin/python3 -f make-linux
11:00:25 Traceback (most recent call last):
11:00:25   File "/home/iojs/build/ws/./configure", line 28, in <module>
11:00:25     import configure
11:00:25   File "/home/iojs/build/ws/configure.py", line 2323, in <module>
11:00:25     run_gyp(gyp_args)
11:00:25   File "/home/iojs/build/ws/tools/gyp_node.py", line 44, in run_gyp
11:00:25     rc = gyp.main(args)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/__init__.py", line 680, in main
11:00:25     return gyp_main(args)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/__init__.py", line 647, in gyp_main
11:00:25     [generator, flat_list, targets, data] = Load(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/__init__.py", line 157, in Load
11:00:25     result = gyp.input.Load(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 2987, in Load
11:00:25     LoadTargetBuildFile(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 481, in LoadTargetBuildFile
11:00:25     LoadTargetBuildFile(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 427, in LoadTargetBuildFile
11:00:25     ProcessVariablesAndConditionsInDict(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1399, in ProcessVariablesAndConditionsInDict
11:00:25     ProcessVariablesAndConditionsInList(value, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1412, in ProcessVariablesAndConditionsInList
11:00:25     ProcessVariablesAndConditionsInDict(item, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1391, in ProcessVariablesAndConditionsInDict
11:00:25     ProcessVariablesAndConditionsInDict(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1373, in ProcessVariablesAndConditionsInDict
11:00:25     ProcessConditionsInDict(the_dict, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1244, in ProcessConditionsInDict
11:00:25     ProcessVariablesAndConditionsInDict(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1373, in ProcessVariablesAndConditionsInDict
11:00:25     ProcessConditionsInDict(the_dict, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1244, in ProcessConditionsInDict
11:00:25     ProcessVariablesAndConditionsInDict(
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1399, in ProcessVariablesAndConditionsInDict
11:00:25     ProcessVariablesAndConditionsInList(value, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 1416, in ProcessVariablesAndConditionsInList
11:00:25     expanded = ExpandVariables(item, phase, variables, build_file)
11:00:25   File "/home/iojs/build/ws/tools/gyp/pylib/gyp/input.py", line 946, in ExpandVariables
11:00:25     py_module.DoMain(parsed_contents[1:])
11:00:25   File "/home/iojs/build/ws/tools/v8_gypfiles/GN-scraper.py", line 15, in DoMain
11:00:25     match = matches.group(1)
11:00:25 AttributeError: 'NoneType' object has no attribute 'group' while loading dependencies of /home/iojs/build/ws/node.gyp while trying to load /home/iojs/build/ws/node.gyp

richardlau avatar Sep 18 '24 14:09 richardlau

Test CI: https://ci.nodejs.org/job/node-test-commit-linuxone/45921/ ✅

richardlau avatar Sep 18 '24 14:09 richardlau

Pushed to canary-base

targos avatar Sep 19 '24 06:09 targos

https://github.com/nodejs/node-v8/actions/runs/10935492362 is running with it.

targos avatar Sep 19 '24 06:09 targos