node-v8
node-v8 copied to clipboard
Restructure repository branches
- [x] Create
mainbranch in this repository- [x] Set it as default branch
- [x] Keep
canarybranch as we have today- [ ] Alternatively have a
canary/folder which is a copy ofnodejs/nodewith patches applied - [ ] Alternatively 2 keep the V8 canary as a
v8-canarybranch onnodejs/nodeand have it as a submodule here
- [ ] Alternatively have a
- [ ] Ensure Jenkins fetches the
canarybranch for relevant jobs - [x] Use GitHub Actions to update the
canarybranch - [ ] Use GitHub Actions to open the major V8 upgrade PR on
nodejs/node - [ ] Drop
canary-basebranch onnodejs/nodeand use patch files on this repository instead (need to experiment to ensure it doesn't worsen our workflow)
We can start by creating the main branch with an empty README, and then slowly we can work on the other changes there (via PRs) and then once we're confident this new system is working and is better than the current state we can switch it.
Drop
canary-basebranch onnodejs/nodeand use patch files on this repository instead.
I'm not opposed to it, but having a branch to manage the canary patches helps me a lot because I can easily use git cherry-pick and git rebase. We need to make sure patch files don't slow down the regular processes of
- keeping gyp files up to date
- preparing the V8 update PRs in
nodejs/node
Definitely. I'm proposing these changes because I do believe they will make the overall process faster (or at least simpler), but we'll definitely need some experimentation in order to get it right.
Edit: for major V8 upgrades, we could even have an Action that opens the PR and updates it every time we update the patches list (edit 2: and dropping canary-base is not a requirement for that, so I'll go ahead and add it to the list :) )
Besides dropping the canary-base branch, what are your thoughts on the other changes?
Other changes SGTM