node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

Why is `package-lock.json` ignored?

Open cinderblock opened this issue 1 year ago • 0 comments

This was first brought up in a review. A couple people mentioned this. No action was taken.

https://github.com/nodejs/node-gyp/pull/1573/files/020e2bdb6836b57462cccac6083a67f074019658#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947

Why is package-lock.json ignored? https://github.com/nodejs/node-gyp/blob/main/.gitignore#L7

The general consensus seems to bee that it should be committed. If there is a reason it shouldn't, it should probably be listed alongside the ignore (as a comment).

cinderblock avatar Aug 19 '24 02:08 cinderblock