node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

try libnode.dll first in load_exe_hook

Open zombieyang opened this issue 2 years ago • 2 comments

Checklist
  • [x] npm install && npm test passes
  • [ ] tests are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
Description of change

It is a following PR of https://github.com/nodejs/node/issues/47682.

I've tried to rename my executable to node.exe but the error is still there. That's because the node.js's symbol is in libnode.dll but not in my executable. So, GetModuleHandle(NULL) will not work.

However, I think we can try to load libnode.dll first. If failed then fallback to try the executable. That will solve the problem and keep the original path work either. Maybe it is looks like a edge case, but as Node.js has a embedding tutorial in the doc, I think it's worth to do this.

Or please tell me if there is a more simple way to solve my problem.


Test is not included because I need to provide a huge nodedll binary.

Thank you, I love node.js.

zombieyang avatar Apr 26 '23 13:04 zombieyang

Can anyone review?

Kreijstal avatar Oct 08 '24 12:10 Kreijstal

I'm not quite sure if it still make sense after such a long time. Maybe you can consider cherry-picking dd56ec0

zombieyang avatar Oct 08 '24 15:10 zombieyang

I have rebased this PR to include only https://github.com/nodejs/node-gyp/commit/dd56ec0637f90ecae9020c5dfff14e42904865b4

lukekarrys avatar Dec 02 '24 20:12 lukekarrys

I have rebased this PR to include only dd56ec0

Thank you

Kreijstal avatar Dec 02 '24 20:12 Kreijstal

I have rebased this PR to include only dd56ec0

Thank you, will it merge?

zombieyang avatar Dec 03 '24 01:12 zombieyang

I have rebased this PR to include only dd56ec0

Thank you, will it merge?

i hope so

Kreijstal avatar Dec 10 '24 07:12 Kreijstal