node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

GitHub Workflows security hardening

Open sashashura opened this issue 2 years ago • 1 comments

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Sep 26 '22 20:09 sashashura

sgtm, someone else with more extensive Actions experience want to weigh in? I haven't played with permissions myself yet.

rvagg avatar Sep 27 '22 04:09 rvagg

Is it ready to be merged?

sashashura avatar Dec 01 '22 00:12 sashashura