node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

fix: update example to reflect proper argument usage

Open itsknob opened this issue 3 years ago • 5 comments

The example had a space instead of an equals sign (=) where the table below specifies that the argument should utilize an equals sign (=) for it's key-value flags.

Checklist
  • [x] npm install && npm test passes
  • [x] tests are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
Description of change

itsknob avatar Aug 11 '22 18:08 itsknob

Does it work either way or does only one way work? On Linux, macOS, and Windows?

cclauss avatar Oct 17 '22 19:10 cclauss

Since I opened this a while ago, my memory is a little fuzzy. I think the best information I have for you is this screenshot. This is MacOS on an M1 Chip. After specifying the Python 2.7 path as an arg without an equals sign (=), it seems as though the node-gyp utilized the Python 3 installation.

image

All other arguments in the docs used an equals sign. I'm not entirely sure that the cause for using the wrong python version was due to the lack of the equals sign, but this MR was more just to standardize the way the arguments are laid out in the documentation.

itsknob avatar Oct 17 '22 19:10 itsknob

Node-gyp is using Python 3 because Python 2 died more than 1,000 days ago on 1/1/2020.

cclauss avatar Oct 17 '22 19:10 cclauss

Legacy software still exists, I was installing node-gyp 3.8 for an application running node 12. While I understand that it's not supported, this isn't a bug report. It's a docs consistency update.

If this doesn't seem relevant or worth the effort, feel free to close this.

itsknob avatar Oct 17 '22 19:10 itsknob

node-gyp 3.8 loves legacy Python.

cclauss avatar Oct 17 '22 19:10 cclauss