node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

[question]: Is there a timeline for dropping node10 support?

Open wraithgar opened this issue 3 years ago • 6 comments

We are in the process of updating our support matrix for the npm cli and its dependencies. One of these dependencies, make-fetch-happen, just had its engines field updated to drop node10 support. We'd like to help keep node-gyp up to date on that dependency but it still supports node >= 10.12.0.

Are there plans or is there a timeline for updating this field?

wraithgar avatar Jan 26 '22 21:01 wraithgar

https://nodejs.org/en/about/releases/

cclauss avatar Jan 26 '22 21:01 cclauss

@cclauss that's the nodejs release cycle, nothing on there mentions node-gyp? Does this mean it can drop node10 now and it was just overlooked?

wraithgar avatar Jan 26 '22 22:01 wraithgar

no plans, we can be flexible around npm's needs on this I think, and we should be able to bump it to at least 12.0.0 (unless you want to suggest a later release of 12?)

rvagg avatar Jan 27 '22 00:01 rvagg

Might I suggest this as the engines field

https://github.com/MylesBorins/node-osc/blob/main/package.json#L14

It scoped to versions to 12/14 that support the full esm implementation

MylesBorins avatar Jan 27 '22 01:01 MylesBorins

sgtm

rvagg avatar Jan 27 '22 01:01 rvagg

https://github.com/nodejs/node-gyp/pull/2601

wraithgar avatar Jan 27 '22 14:01 wraithgar