node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

support v8 revert

Open gengjiawen opened this issue 4 years ago • 4 comments

support revert v8 commit by hash, should be usefully when test V8 function. Like https://github.com/nodejs/node/pull/35415#issuecomment-700987060, I have a guess, but cumbersome reverting the commit in node.js repo.

gengjiawen avatar Oct 02 '20 13:10 gengjiawen

Would be useful for https://github.com/nodejs/node-v8/issues/175 too. We probably just need to add --reverse to the git apply command to make it work

joyeecheung avatar Oct 20 '20 14:10 joyeecheung

Also my guess for https://github.com/nodejs/node/pull/35415#issuecomment-700987060 is right, though I manually revert them, take quite some time (The final fix is not revert though, I found a workaround).

gengjiawen avatar Oct 20 '20 14:10 gengjiawen

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Jan 19 '21 01:01 github-actions[bot]

not stale.

gengjiawen avatar Jan 19 '21 01:01 gengjiawen