node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

Changing commit messages should be improved

Open BridgeAR opened this issue 5 years ago • 2 comments

Right now when changing the commit messages a file is added and that has to be changed. This is not really straight forward:

? Use this message? No
Please manually edit /home/ruben/repos/node/node/.ncu/33405/8e7685a4d15a-message, then run
`git commit --amend -F /home/ruben/repos/node/node/.ncu/33405/8e7685a4d15a-message` to finish amending the message

It would be easier to apply the metadata right away and to let the user then change the commit message with git commit --amend. That would be more straight forward and easier to handle for people landing PRs.

BridgeAR avatar May 23 '20 19:05 BridgeAR

It should be good to add a question here about copying it and use clipboardy.writeSync to copy it.

joyeecheung avatar Jun 08 '20 15:06 joyeecheung

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Sep 07 '20 00:09 github-actions[bot]

Resolved by https://github.com/nodejs/node-core-utils/commit/811de87206806246a98033c60c5db2557d56da12. Closing, please reopen if I'm mistaken.

aduh95 avatar Mar 10 '23 23:03 aduh95