git node metadata doesn't support http proxy

[starkwang]

In node-core-utils, we use node-fetch to make http requests. But this library doesn't support proxy in its options, which makes requests failed in some cases.

Suggestion: using request or got to replace it.

[richardlau]

In node-core-utils, we use node-fetch to make http requests. But this library doesn't support proxy in its options, which makes requests failed in some cases.

Suggestion: using request or got to replace it.

request probably isn’t such a good idea: https://github.com/request/request/issues/3142

[joyeecheung]

node-fetch supports custom agents so we could just use something like https://www.npmjs.com/package/proxy-agent for proxy support. It shouldn't be too hard as all HTTP requests are routed to https://github.com/nodejs/node-core-utils/blob/master/lib/request.js . This can be a .ncurc configuration or a CLI option - or unless someone wants to deal with all the proxy environment variable conventions out there...

[github-actions[bot]]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.