node-core-test icon indicating copy to clipboard operation
node-core-test copied to clipboard

Use same linter as node

Open juliangruber opened this issue 3 years ago • 3 comments

  • https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/Makefile#L1340-L1375
  • https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/.eslintrc.js
  • https://github.com/nodejs/node/tree/2fe4e9473fb50630326754886dee1d301a1a661e/tools/eslint-rules
  • https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/tools/node_modules/eslint-plugin-node-core/index.js

juliangruber avatar Jul 09 '22 15:07 juliangruber

@aduh95 how do you feel about this? What about we package all of the above in a new module, for node-core-* projects to consume?

juliangruber avatar Jul 09 '22 15:07 juliangruber

Ideally we would use https://github.com/nodejs/eslint-plugin-nodejs-internal, needs some work though (e.g. https://github.com/nodejs/eslint-plugin-nodejs-internal/issues/1).

aduh95 avatar Jul 09 '22 15:07 aduh95

For interest, parseArgs started down this route and is also intending to switch to https://github.com/nodejs/eslint-plugin-nodejs-internal:

  • https://github.com/pkgjs/parseargs/issues/17
  • https://github.com/pkgjs/parseargs/issues/90

shadowspawn avatar Jul 09 '22 22:07 shadowspawn