nodejs
build: add win32 convenience build rule
Per: https://github.com/nodejs/node/issues/27 See: https://github.com/nodejs/node/issues/27#issuecomment-106047682
ORIGINAL-PR: https://github.com/joyent/node/pull/9085 PORT-FROM: https://github.com/joyent/node/commit/6168fe6
/cc: @misterdjules
not sure about the status of nosnapshot, I can't recall details but I know we've had some changes in io.js on that front
also @jasnell, it'd be helpful to /cc @nodejs/build on all changes related to configure, Makefile and vcbuild.bat cause there's lots of context around those bits
Is nosnapshot for v8 snapshots? We now want those enabled here, security issues have been fixed.
FWIW, this gives a bit of context around this change: https://github.com/nodejs/io.js/issues/528.
@misterdjules We've re-enabled snapshots in io.js by recommendation from the v8 team since existing insecurities had been resolved.
Besides V8 snapshots, the point of having a build-release argument to vcbuild.bat was to avoid duplicating build parameters across Jenkins jobs when creating Node.js release installers on Windows.
That makes these jobs' maintenance easier: instead of modifying every Jenkins job, we just change what gets enabled when running vcbuild build-release in vcbuild.bat. Plus it's versioned.
If io.js doesn't have that, then I think it's a good thing to add.
Agreed, we currently put too much logic into jenkins and we need to shift it back into vcbuild.bat and Makefile so I'm happy with this direction. The only question is about nosnapshot.
The only question is about nosnapshot.
Again, if it disables v8 snapshots, it shouldn't be there anymore. :P
As others have already pointed out, nosnapshot=1 sound not be set. Other than that, +1 for the vcbuild.bat change.
