node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

Ensure chakrashim extracts information from right context

Open kunalspathak opened this issue 9 years ago • 3 comments

  • Version:
  • Platform:
  • Subsystem:

As mentioned in recent PR #96, for repl scenario we were not extracting the global object from right context. Instead we simply extracted from current context leading to new context being collected. There are multiple places where we do one of 2 things that needs to be reviewed.

  • IsolateShim::GetCurrent()->GetCurrentContextShim();
  • jsrt::ContextShim::GetCurrent()

kunalspathak avatar Jul 12 '16 00:07 kunalspathak

@kunalspathak I see several commits that referenced this issue- do you know if this still needs to be fixed or whether it can be closed?

digitalinfinity avatar Aug 30 '17 23:08 digitalinfinity

Commits 983c0b8 and 0125f12 just points to the severity/implication around this issue. This definitely need to be fixed.

kunalspathak avatar Aug 30 '17 23:08 kunalspathak

Ok, thanks

digitalinfinity avatar Aug 30 '17 23:08 digitalinfinity