node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

SharedArrayBuffers can cause crashes when inspected in certain ways

Open MSLaguana opened this issue 7 years ago • 3 comments
trafficstars

Something non-obvious has changed between the current state of things and the nightly integration I'm about to complete, which causes shared array buffers to return a null pointer for their contents, which is triggering an assert in node. I'm disabling the test for now.

MSLaguana avatar Aug 17 '18 22:08 MSLaguana

I'm still not sure what change caused this to come to the surface, but it looks like the problem is we don't currently have a JSRT way to extract the contents of s SharedArrayBuffer; There are JsGetArrayBufferStorage and JsGetTypedArrayStorage but neither of those accept shared array buffers as inputs.

MSLaguana avatar Aug 20 '18 15:08 MSLaguana

Disabled in 06ff556f9eb0c1c926b317373f17c8c12d8c08b8

kfarnung avatar Aug 20 '18 20:08 kfarnung

This is also impacting test-assert-typedarray-deepequal.js

MSLaguana avatar Aug 21 '18 23:08 MSLaguana